Any comments would be, as always, appreciated. -Nish Description: Reorder set_current_state() and add_wait_queue(). There is a chance that a signal could be missed in between the two functions currently. Signed-off-by: Nishanth Aravamudan Signed-off-by: Domen Puncer --- kj-domen/drivers/video/pxafb.c | 2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff -puN drivers/video/pxafb.c~reorder-state-drivers_video_pxafb drivers/video/pxafb.c --- kj/drivers/video/pxafb.c~reorder-state-drivers_video_pxafb 2004-12-25 01:35:18.000000000 +0100 +++ kj-domen/drivers/video/pxafb.c 2004-12-25 01:35:18.000000000 +0100 @@ -725,8 +725,8 @@ static void pxafb_disable_controller(str DPRINTK("Disabling LCD controller\n"); - add_wait_queue(&fbi->ctrlr_wait, &wait); set_current_state(TASK_UNINTERRUPTIBLE); + add_wait_queue(&fbi->ctrlr_wait, &wait); LCSR = 0xffffffff; /* Clear LCD Status Register */ LCCR0 &= ~LCCR0_LDM; /* Enable LCD Disable Done Interrupt */ _