Hi, Please consider applying. Description: Use msleep_interruptible() instead of schedule_timeout(). The current code is not wrong; however a change to msleep_interruptible() has two major benefits: 1) consistency across the kernel and 2) uses human-sensible time units (msecs). Change the units of timeleft appropriately to msecs. Signed-off-by: Nishanth Aravamudan Signed-off-by: Domen Puncer --- kj-domen/fs/xfs/linux-2.6/xfs_super.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff -puN fs/xfs/linux-2.6/xfs_super.c~msleep_interruptible-fs_xfs_linux-2.6_xfs_super fs/xfs/linux-2.6/xfs_super.c --- kj/fs/xfs/linux-2.6/xfs_super.c~msleep_interruptible-fs_xfs_linux-2.6_xfs_super 2005-01-23 00:24:22.000000000 +0100 +++ kj-domen/fs/xfs/linux-2.6/xfs_super.c 2005-01-23 00:24:22.000000000 +0100 @@ -72,6 +72,7 @@ #include #include #include +#include STATIC struct quotactl_ops linvfs_qops; STATIC struct super_operations linvfs_sops; @@ -483,10 +484,9 @@ xfssyncd( wake_up(&vfsp->vfs_wait_sync_task); INIT_LIST_HEAD(&tmp); - timeleft = (xfs_syncd_centisecs * HZ) / 100; + timeleft = xfs_syncd_centisecs * 10; for (;;) { - set_current_state(TASK_INTERRUPTIBLE); - timeleft = schedule_timeout(timeleft); + timeleft = msleep_interruptible(timeleft); /* swsusp */ try_to_freeze(PF_FREEZE); if (vfsp->vfs_flag & VFS_UMOUNT) @@ -500,7 +500,7 @@ xfssyncd( */ if (!timeleft || list_empty(&vfsp->vfs_sync_list)) { if (!timeleft) - timeleft = (xfs_syncd_centisecs * HZ) / 100; + timeleft = xfs_syncd_centisecs * 10; INIT_LIST_HEAD(&vfsp->vfs_sync_work.w_list); list_add_tail(&vfsp->vfs_sync_work.w_list, &vfsp->vfs_sync_list); _