From: "Stephen Biggs" Subject: [KJ] [PATCH][RESUBMIT][5/21] drivers/isdn/hisax/* - compile warning cleanup compile warning cleanup - handle copy_to/from_user error returns Signed-off-by: Stephen Biggs Signed-off-by: Domen Puncer --- config.c | 14 ++++++++++++-- 1 files changed, 12 insertions(+), 2 deletions(-) Index: quilt/drivers/isdn/hisax/config.c =================================================================== --- quilt.orig/drivers/isdn/hisax/config.c +++ quilt/drivers/isdn/hisax/config.c @@ -631,7 +631,12 @@ int HiSax_readstatus(u_char __user *buf, count = cs->status_end - cs->status_read + 1; if (count >= len) count = len; - copy_to_user(p, cs->status_read, count); + if (copy_to_user(p, cs->status_read, count)) { + printk(KERN_ERR + "HiSax:%s: copy_to_user failed!\n", + __FUNCTION__); + return -EFAULT; + } cs->status_read += count; if (cs->status_read > cs->status_end) cs->status_read = cs->status_buf; @@ -642,7 +647,12 @@ int HiSax_readstatus(u_char __user *buf, cnt = HISAX_STATUS_BUFSIZE; else cnt = count; - copy_to_user(p, cs->status_read, cnt); + if (copy_to_user(p, cs->status_read, cnt)) { + printk(KERN_ERR + "HiSax:%s: copy_to_user failed!\n", + __FUNCTION__); + return -EFAULT; + } p += cnt; cs->status_read += cnt % HISAX_STATUS_BUFSIZE; count -= cnt;