From: Christophe Lucas Subject: [KJ] [PATCH][RESEND] Audit return code : drivers/macintosh/apm_emu.c Audit return codes (and handle failure correctly) for misc_register. Signed-off-by: Christophe Lucas --- apm_emu.c | 11 ++++++++--- 1 files changed, 8 insertions(+), 3 deletions(-) Index: quilt/drivers/macintosh/apm_emu.c =================================================================== --- quilt.orig/drivers/macintosh/apm_emu.c +++ quilt/drivers/macintosh/apm_emu.c @@ -515,19 +515,24 @@ static struct miscdevice apm_device = { static int __init apm_emu_init(void) { + int ret; struct proc_dir_entry *apm_proc; if (sys_ctrler != SYS_CTRLER_PMU) { printk(KERN_INFO "apm_emu: Requires a machine with a PMU.\n"); return -ENODEV; } - + + ret = misc_register(&apm_device); + if (ret) { + printk(KERN_WARNING "apm_emu: Unable to register misc device.\n"); + return ret; + } + apm_proc = create_proc_info_entry("apm", 0, NULL, apm_emu_get_info); if (apm_proc) apm_proc->owner = THIS_MODULE; - misc_register(&apm_device); - pmu_register_sleep_notifier(&apm_sleep_notifier); printk(KERN_INFO "apm_emu: APM Emulation %s initialized.\n", driver_version);