[PATCH] olympic: check return code for /proc entry creation From: Kirk True The IBM Olympic driver assumes that the call to create_proc_read_entry always succeeds. This patch simply logs appropriately whether it was actually created or not. Also added KERN_* constants as per Christophe Lucas' recommendation. Signed-off-by: Kirk True Signed-off-by: Alexey Dobriyan Index: linux-kj/drivers/net/tokenring/olympic.c =================================================================== --- linux-kj.orig/drivers/net/tokenring/olympic.c 2005-10-28 16:28:51.000000000 +0400 +++ linux-kj/drivers/net/tokenring/olympic.c 2005-10-28 16:29:56.000000000 +0400 @@ -267,11 +267,16 @@ static int __devinit olympic_probe(struc register_netdev(dev) ; printk("Olympic: %s registered as: %s\n",olympic_priv->olympic_card_name,dev->name); if (olympic_priv->olympic_network_monitor) { /* Must go after register_netdev as we need the device name */ + struct proc_dir_entry *proc_dir_entry; char proc_name[20] ; strcpy(proc_name,"net/olympic_") ; strcat(proc_name,dev->name) ; - create_proc_read_entry(proc_name,0,NULL,olympic_proc_info,(void *)dev) ; - printk("Olympic: Network Monitor information: /proc/%s\n",proc_name); + proc_dir_entry = create_proc_read_entry(proc_name,0,NULL,olympic_proc_info,dev); + + if (proc_dir_entry) + printk(KERN_INFO "Olympic: Network Monitor information: /proc/%s\n",proc_name); + else + printk(KERN_WARNING "Olympic: Network Monitor information: /proc/%s could not be created\n",proc_name); } return 0 ;